Refactor struct xrdp_client_info #3490
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The struct is refactored into items shared with xorgxrdp, and items which are private to xrdp The name 'struct xrdp_client_info' is retained for xorgxrdp, for compatibility.
|
I've decided I'm not that happy with this approach. I'll close this one and try again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for comments.
The
xrdp_client_infostruct is refactored into items shared with xorgxrdp, and items which are private to xrdp.The name
struct xrdp_client_infois retained for xorgxrdp, for compatibility. Thestruct xrdp_client_info_alltype is used within xrdp only.@metalefty - what do you think of this approach? Does it help the maintainability or not? Any other suggestions?
I haven't tested this yet.